Answer by user114771 for Team doesn't take my code review comments seriously
A technical code-reviewer gains authority by, essentially, being wise, right, and capable of explaining why he's wise and right. Not by management fiat.So you're going to have to win hearts and...
View ArticleAnswer by Matthew Gaiser for Team doesn't take my code review comments seriously
You are trying to change an embedded way of doing things which probably arose due to the incentive structure of the companyMy company technically has coding standards, code review, documentation plans,...
View ArticleAnswer by David for Team doesn't take my code review comments seriously
I think the focus on what your authority is and how you get people to comply is mistaken.The purpose of code review is to catch bugs and improve code quality, not to produce perfect code. Insisting...
View ArticleAnswer by Tymoteusz Paul for Team doesn't take my code review comments seriously
I very much like Joe's answer, but I'll expand on a few very alarming signs to me.I have to constantly remind them to follow the agreed upon code standards, to document stuff and just take...
View ArticleAnswer by Hakan for Team doesn't take my code review comments seriously
I cannot simply ignore the basic mistakes that are made in the reviews and let that code go in the production.Then don't. If you found a defect, write it down as a ticket and don't accept the code...
View ArticleAnswer by bharal for Team doesn't take my code review comments seriously
Code quality doesn't matter. Sales do. Making a new product does, because it boosts sales. Re-write the code a hundred times, and your sales won't go up. With that idea celebrated in the back of your...
View ArticleAnswer by aaaaa says reinstate Monica for Team doesn't take my code review...
To summarize the question, as it reads now:I want to achieve consistency in the code and avoid stupid bugs in productionPart of my job is code reviewerI have to constantly remind them to follow the...
View ArticleAnswer by Joe Strazzere for Team doesn't take my code review comments seriously
Their attitude is starting to annoy me and almost stress me out. This attitude is same throughout all levels be it a junior developer or a more senior developer than me.I don't know if it is the...
View ArticleAnswer by Oscar for Team doesn't take my code review comments seriously
Ask your manager what is expected of you in code-reviews (possibly with some anonymised examples from your reviews), get it in documented publicly and specifically, and follow that as best you can. If...
View ArticleTeam doesn't take my code review comments seriously
I am a mid level software developer in a small software company. I have been here for the last 8 months and due to my approach with code reviews I was added to the mandatory reviewers list early on.I...
View Article
